Since there are many places (like crash reporting, early init code) where stack is not availablereliable, we have rely on custom register clobber list.
Maybe the situations where veneers are needed just dont happen inside TF in practice, but the ABI doesnt specify them so it still seems like a very bad idea to trust these to hold their value across branch instructions ever. The linker is always allowed to automatically insert a veneer in the call which clobbers these registers. I tried to pick the extra registers for multi-console carefully so that most code that was written for the existing crash handlers should still work (i.e. I think the rest of it barely manages to scoot around conflicts. I think that in the crash handling code we didnt do it because we never thought that we would need to use more than really simple functions after a crash. However, will it be enough to move x16 and x17 I havent checked all the code in this macro, but Id be surprised if x16 and x17 were the only problems here. Sure, if you are using the multi console for crash output then you need to use callee-saved registers, I didnt realize about that problem because only rockchip platforms do that, as far as I know. Some parts of the multi-console core explicitly make use of these as scratch registers, so that would definitely blow up. Stevenson telugu christian songs free download However, I agree that it isnt a bad idea to change the registers, using x26 and x27 makes the code more intuitive. Mediatek Arm Mt8312V Firmware Code More Intuitive The registers arent used as a callee-saved registers, so it is fine. If you take a look at the macros there it explicitly says that x16 and x17 are used to pass the base addresses. In fact, do you have to copy this file Cant you just factor it out into a platmediatekcommon). This should probably be fixed in the mt8173 version as well. You can see the other half in corebootsrcsocrockchiprk3399bl31platparams.c.). GPIOs), I would encourage you to just copy the parameter passing mechanism from platrockchipcommonparamssetup.c.
If there are additional platform-specific parameters you need to pass from coreboot into B元1, which is likely (e.g. Mediatek Arm Mt8312V Firmware Driver Should Be.
0 kommentar(er)
